[#987] Move Terms/Privacy consent into wallet connect modal#996
Merged
realproject7 merged 1 commit intomainfrom Apr 24, 2026
Merged
[#987] Move Terms/Privacy consent into wallet connect modal#996realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
- Add appInfo.disclaimer to RainbowKitProvider with Terms and Privacy Policy links - Remove inline consent text from ConnectWallet.tsx - Bump version 1.1.0 → 1.1.1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 24, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The consent copy is now configured in RainbowKit where the issue requested it, and the inline duplicate below the connect button has been removed. The change is minimal and follows the intended integration pattern.
Findings
- None.
Decision
Approving. The implementation matches issue #987. e2e and lint-and-typecheck were still pending at the time of review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #987
appInfo.disclaimertoRainbowKitProviderinproviders.tsx— consent text with Terms and Privacy links now appears inside the connect modalConnectWallet.tsx(was below the connect button)Test plan
🤖 Generated with Claude Code